Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RANDOM for NEURON. #1367

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Implement RANDOM for NEURON. #1367

merged 3 commits into from
Aug 12, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jul 23, 2024

No description provided.

@1uc 1uc force-pushed the 1uc/register-random branch from a384863 to 9fde622 Compare July 23, 2024 10:28
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (c5052b9) to head (0548ebd).
Report is 2 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   86.75%   86.70%   -0.05%     
==========================================
  Files         180      180              
  Lines       13669    13689      +20     
==========================================
+ Hits        11858    11869      +11     
- Misses       1811     1820       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review July 23, 2024 11:21
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 31, 2024
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #224434 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc force-pushed the 1uc/register-random branch from c3b56a5 to 0548ebd Compare August 12, 2024 08:56
Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially since it fixes a bunch of models in the channel benchmark.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Aug 12, 2024
@1uc 1uc merged commit 22dc559 into master Aug 12, 2024
24 checks passed
@1uc 1uc deleted the 1uc/register-random branch August 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants